Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "session: add physical table placement_policy in mysql schema" #27250

Merged
merged 5 commits into from
Aug 17, 2021
Merged

Revert "session: add physical table placement_policy in mysql schema" #27250

merged 5 commits into from
Aug 17, 2021

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Aug 16, 2021 •
edited
Loading

Reverts #27054

After discussion, we incline to store the PLACEMENT POLICY into meta.
New PR Refer: #27251

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 16, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • morgo
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

@AilinKid: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 16, 2021
@AilinKid AilinKid mentioned this pull request Aug 16, 2021
Merged
2 tasks
@github-actions github-actions bot added sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels Aug 16, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 16, 2021
@morgo morgo self-requested a review August 16, 2021 20:59
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 16, 2021
@morgo
Copy link
Contributor

morgo commented Aug 16, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 910ca60

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 16, 2021
@AilinKid
Copy link
Contributor Author

/merge

1 similar comment
@AilinKid
Copy link
Contributor Author

/merge

@AilinKid
Copy link
Contributor Author

/build

@AilinKid
Copy link
Contributor Author

/run-unit-test

@AilinKid
Copy link
Contributor Author

/merge

@AilinKid AilinKid removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 17, 2021
@AilinKid
Copy link
Contributor Author

/merge

@ti-chi-bot ti-chi-bot merged commit dd34d48 into master Aug 17, 2021
@ti-chi-bot ti-chi-bot deleted the revert-27054-add-placement-policy branch August 17, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@morgo morgo morgo approved these changes

Assignees
No one assigned
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AilinKid @ti-chi-bot @morgo @xhebox